[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] gnu: Add python-pyqi.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH 1/2] gnu: Add python-pyqi. |
Date: |
Tue, 26 Apr 2016 16:24:51 +0200 |
Leo Famulari <address@hidden> writes:
> On Sun, Apr 24, 2016 at 10:27:39PM +1000, Ben Woodcroft wrote:
>> * gnu/packages/python.scm (python-pyqi, python2-pyqi): New variables.
>
> Thanks for the patches!
>
>> + (source
>> + (origin
>> + (method url-fetch)
>> + ;; Use GitHub as source because PyPI archive does not contain tests.
>> + (uri (string-append "https://github.com/biocore/pyqi/archive/"
>> + version ".tar.gz"))
>
> I've had some success asking upstream authors to start releasing their
> test suites on PyPi. YMMV. This is not a "blocker".
>
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-before 'build 'remove-version-requirement
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute* "setup.py"
>> + (("if ver not in \\['2.7', '3.3'\\]:")
>> + (string-append
>> + "if ver not in ['2.7', '3.3', '"
>> + (string-take (string-take-right
>> + (assoc-ref inputs "python") 5) 3)
>> + "']:")))))
>
> I assume everything works with this change :)
>
>> + (home-page "http://bipy.github.io/pyqi")
>
> This is what PyPi calls the home page, but I get 404. Did it work for
> you, meaning I am experiencing a transient error? Or should we use
> something else?
It’s a 404 for me too. Maybe change this to
https://github.com/biocore/pyqi
?
~~ Ricardo