Re: [PATCH v4 1/9] gnu: cross: Use CROSS_*_INCLUDE_PATH for system headers.

[Andy Wingo]

On Sun 24 Apr 2016 23:40, Jan Nieuwenhuizen <address@hidden> writes:

> +                    (setenv "CPP" (string-append gcc "/bin/cpp"))
> +                    (for-each (lambda (var)
> +                                (and-let* ((value (getenv var))
> +                                           (path (search-path-as-string->list
> +                                                  value))
> +                                           (native-path
                                               ^^

Bad indentation here; it should be indented like let*

> +                                            (list->search-path-as-string
> +                                             (remove cross? path) ":"))))
> +                                (let* ((path (search-path-as-string->list
> +                                              (getenv var)))

However given this, both "value" and "path" should succeed without
error...

> +                                       (native-path
> +                                        (and path
> +                                             (list->search-path-as-string
> +                                              (remove cross? path) ":"))))

And this is a repeat?  Perhaps you meant to replace the and-let* block,
or to remove this one?  I would lean towards not using and-let* fwiw :)

> +                                  (if native-path (setenv var native-path))))

For one-armed ifs, please use "when" or "unless".  Tx :)

Andy