[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] gnu: add python-maxminddb and python2-maxminddb
From: |
Leo Famulari |
Subject: |
Re: [PATCH 5/7] gnu: add python-maxminddb and python2-maxminddb |
Date: |
Mon, 18 Apr 2016 16:14:48 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sun, Apr 17, 2016 at 10:50:55PM +0200, Hartmut Goebel wrote:
> * gnu/packages/python.scm: (python-maxminddb) (python2-maxminddb):
> New functions.
[...]
> + (arguments
> + ;; tests require a copy of the maxminddb which is not included
> + `(#:tests? #f))
Should the maxminddb be packaged so that we can run the tests?
> + (synopsis "Reader for the MaxMind DB format")
> + (description "This is a Python module for reading MaxMind DB files. The
> +module includes both a pure Python reader and an optional C extension.
> +
> +MaxMind DB is a binary file format that stores data indexed by IP address
> +subnets (IPv4 or IPv6).")
Can you explain to the reader what the purpose of the MaxMind DB is?
> + (properties `((python2-variant . ,(delay python2-maxminddb))))))
> +
> +(define-public python2-maxminddb
> + (let ((base (package-with-python2 (strip-python2-variant
> python-maxminddb))))
> + (package (inherit base)
> + (inputs
> + `(("python2-ipaddr" ,python2-ipaddr)
> + ,@(package-inputs base))))))
I see you already know to use the python2-variant system. Feel free to
move setuptools here if that works for python-maxminddb.
- [PATCH 0/7] Some new python packages, Hartmut Goebel, 2016/04/17
- [PATCH 3/7] gnu: add python-selenium and python2-selenium, Hartmut Goebel, 2016/04/17
- [PATCH 5/7] gnu: add python-maxminddb and python2-maxminddb, Hartmut Goebel, 2016/04/17
- Re: [PATCH 5/7] gnu: add python-maxminddb and python2-maxminddb,
Leo Famulari <=
- [PATCH 7/7] gnu: add python-geoip2 and python2-geoip2, Hartmut Goebel, 2016/04/17
- [PATCH 1/7] gnu: Add python-tblib and python2-tblib, Hartmut Goebel, 2016/04/17
- [PATCH 4/7] gnu: Add python2-ipaddr, a Python-2-only package, Hartmut Goebel, 2016/04/17