Re: [PATCH] gnu: Add openttd

[Leo Famulari]

On Tue, Apr 12, 2016 at 12:41:58AM +0200, Albin wrote:
> Hi!
> 
> This is my first package for the Guix project.  I've done my best to
> follow all the guidelines.

Thanks for the patch!

> Subject: [PATCH] gnu: Add openttd.

Can you add the "changelog" to the commit message? See commit 6dc609985
for a recent example of the desired format.

> +    (source
> +     (origin (method url-fetch)
> +             ;; The official download URL is
> +             ;; 
> http://binaries.openttd.org/releases/1.6.0/openttd-1.6.0-source.tar.xz
> +             ;; but it doesn't work with `guix download`.  However, it
> +             ;; redirects to the one below (and the SHA sums match).

Is it a problem with `guix download` or with the remote server? Even if
we don't fix the issue, it would be nice to say what the problem is in
this comment.

> +             (snippet
> +              '(begin
> +                 ;; The DOS port contains proprietary software, thus:
> +                 (delete-file-recursively "os/dos")

Okay.

> +                 ;; GNU's not Unix so let's modify the exit dialog.
> +                 (substitute* (find-files "src/lang/" "\\.txt")
> +                   ((":Unix") ":GNU"))))))

I don't think this is necessary.

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             ;; The build scripts don't understand the option
> +             ;; `--enable-fast-install'.
> +             (let ((out (assoc-ref outputs "out")))
> +               (zero?
> +                (system* "./configure"
> +                         ;; At the moment, `lzo' must be disabled
> +                         ;; because the `config.lib' script cannot
> +                         ;; find it.  It is only necessary for loading
> +                         ;; saved games generated by early versions of
> +                         ;; OpenTTD.
> +                         (string-append "--prefix=" out)
> +                         "--without-liblzo2"
> +                         ;; Put the binary in `bin' instead of `games'
> +                         "--binary-dir=bin"))))))))

I see this option in `./configure --help`:

--with-liblzo2[=liblzo2.a]     enables liblzo2 support

Does it work to provide the path to that option? Our lzo package does
build a static library, if that is what OpenTTD requires.

> +    (description "OpenTTD is a game in which you transport goods and
> +passengers by land, water and air.  It is a free implementation of
> +Transport Tycoon Deluxe but with many enhancements including
> +multiplayer mode, internationalization support, conditional orders and
> +the ability to clone, autoreplace and autoupdate vehicles.")

All software in Guix is free software, so I don't think it's necessary
to call this a "free implementation". How about "re-implementation"?

> +    ;; The software contains an in-game downloader from which the user
> +    ;; may find non-functional data licensed under different terms.

I don't know the significance of this. Hopefully somebody else will
comment on this subject.

Upon starting the program, I was prompted to download something related
to graphics. I agreed, and the game seemed to download OpenGFX [0] and
launch correctly, although it also warned me about needed to download
some sound files.

> +    (license license:gpl2)))

Section 10.0 of 'readme.txt' describes the licensing of 3rd party
components. If any of those are included, be sure to add them to a list
here.

[0]
http://dev.openttdcoop.org/projects/opengfx