Re: [PATCH] gnu: Add giac-xcas

[Mathieu Lirzin]

Hello,

Nicolas Goaziou <address@hidden> writes:

> I realized Guix already provided "libao", as "ao" variable. However,
> I don't know why it isn't "public".

In fact it is public.  It is just that the module (gnu packages xiph)
use a different convention which is to define "public" variable with
‘define’ and to add them to the #:export list of the module, instead of
directly using ‘define-public’.  Either way is equivalent in Guile.

> I'm not sure about input "texlive-minimal". Debian package doesn't have
> it. However, configure script checks for latex, makeindex, pdflatex and
> dvips, probably so as to build documentation. OTOH, I don't think
> default make dance builds documentation: it probably copies it directly
> from the tarball, so it may be useless to provide the input. As a last
> point, xcas itself provides a feature to print formulas as LaTeX. So,
> all in all, texlive-minimal may be a propagated-input, AFAIU.

It depends if this feature is essential for using xcas?  If yes then
adding it as a propagated-input is still not required unless "latex,
makeindex, ..." are used using the PATH which could not be the case
since those programs are checked at configure time.

WDYT?

> From: Nicolas Goaziou <address@hidden>
> Date: Sun, 10 Apr 2016 13:53:42 +0200
> Subject: [PATCH 1/2] gnu: Add mpfi
>
> * gnu/packages/multiprecision.scm (mpfi): New variable.
> ---
>  gnu/packages/multiprecision.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/multiprecision.scm b/gnu/packages/multiprecision.scm
> index ad50770..a84d7f5 100644
> --- a/gnu/packages/multiprecision.scm
> +++ b/gnu/packages/multiprecision.scm
[...]
> +(define-public mpfi
> +  (package
> +   (name "mpfi")
> +   (version "1.5.1")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append
> +                  "https://gforge.inria.fr/frs/download.php/file/30130/mpfi-";
> +                  version ".tar.gz"))
> +            (sha256
> +             (base32
> +              "1g2q6i7dqx40p4gw11da6jgfcbzmm26wxc69fwv8zpcdyg32a9za"))))
> +   (build-system gnu-build-system)
> +   (propagated-inputs `(("gmp" ,gmp)   ; <mpfi.h> refers to both
> +                        ("mpfr" ,mpfr)))
> +   (synopsis "C library for arbitrary precision interval arithmetic")
> +   (description "MPFI is intended to be a portable library written in C for
> +arbitrary precision interval arithmetic with intervals represented using MPFR
> +reliable floating-point numbers.  It is based on the GNU MP library and on 
> the
> +MPFR library.  The purpose of an arbitrary precision interval arithmetic is 
> on
> +the one hand to get guaranteed results, thanks to interval computation, and 
> on
> +the other hand to obtain accurate results, thanks to multiple precision
> +arithmetic.")
> +   (license lgpl2.1+)
> +   (home-page "https://perso.ens-lyon.fr/nathalie.revol/software.html";)))
> -- 
> 2.8.0

Looks good to me.  guix lint is happy and the build is reproducible.  I
have modified the indentation to follow our “custom” Emacs rules.  Here
is the updated patch.

0001-gnu-Add-mpfi.patch
Description: Text Data

> From: Nicolas Goaziou <address@hidden>
> Date: Thu, 7 Apr 2016 14:43:15 +0200
> Subject: [PATCH 2/2] gnu: Add giac-xcas
>
> * gnu/packages/algebra.scm (giac-xcas): New variable.
> ---
>  gnu/packages/algebra.scm | 65 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
>
> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
> index abac961..74b3f71 100644
> --- a/gnu/packages/algebra.scm
> +++ b/gnu/packages/algebra.scm
[...]
> +              (sha256
> +               (base32
> +                "0cagh9nnaz7ks299b2bs3lrdclv4xbyis24zc8vf3i25p470bxsf"))
> +              ;; Disable failing test. Actually, the results are correct but
> +              ;; a sorting discrepancy prevents the test from being 
> validated.
> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "check/Makefile.in"
> +                  (("chk_fhan16") "")))))

Is there a particular reason for not patching this within the
‘arguments’ field?  Otherwise everything looks good to me.

Here is an updated patch with the suggested change and minor formatting
fixes.

0002-gnu-Add-giac-xcas.patch
Description: Text Data

Thanks and welcome!

-- 
Mathieu Lirzin