[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] gnu: util-linux: Add "static" output.
From: |
Tobias Geerinckx-Rice |
Subject: |
Re: [PATCH 2/3] gnu: util-linux: Add "static" output. |
Date: |
Sun, 3 Apr 2016 20:29:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
Hullo Leo,
Thanks, as always, for the review!
On 03/04/16 02:53, Leo Famulari wrote:
> On Sat, Apr 02, 2016 at 03:29:33PM +0200, Tobias Geerinckx-Rice wrote:
>> + (add-after
>> + 'install 'move-static-libraries
>
> How about calling the phase 'install-static' as in your btrfs-progs
> patch?
The two phases do subtly (?) different things. INSTALL-STATIC calls an
additional ‘make install-static’ target that wouldn't be run otherwise.
MOVE-STATIC-LIBRARIES moves some static files already installed to OUT
by the default 'install phase to a different output, STATIC.
I don't think drawing explicit parallels between the two (by choosing
identical names) makes anything any clearer, but have no strong feelings
either way.
Kind regards,
T G-R
signature.asc
Description: OpenPGP digital signature
Re: Update btrfs-progs once again and add static output, Leo Famulari, 2016/04/02
Re: Update btrfs-progs once again and add static output, Leo Famulari, 2016/04/11
- Re: Update btrfs-progs once again and add static output, Leo Famulari, 2016/04/12
- Re: Update btrfs-progs once again and add static output, Ludovic Courtès, 2016/04/14
- Re: Update btrfs-progs once again and add static output, Thompson, David, 2016/04/14
- Re: Update btrfs-progs once again and add static output, Leo Famulari, 2016/04/14
- Re: Update btrfs-progs once again and add static output, Ludovic Courtès, 2016/04/15
- Re: Update btrfs-progs once again and add static output, Leo Famulari, 2016/04/15