Re: [PATCH] Add syslog.scm and rsyslog.

[Leo Famulari]

On Sat, Mar 19, 2016 at 06:25:24PM +0100, Danny Milosavljevic wrote:
> Hi,
> 
> this adds gnu/packages/syslog.scm and rsyslog.

Hi, thanks for this, sorry for the delayed review!

> If someone knowledgeable about which license text is which license can check 
> the FIXMEs that would be nice.

My approach to checking licenses is to do a web search for some phrase
from the license, and then check the package's license text against the
results of the search.

Also, these are some good resources:
https://www.gnu.org/licenses/license-list
www.gnu.org/licenses/license-list.html

> 
> That said, it seems inetutils also contains a syslogd (it also auto-starts; I 
> didn't see it before) - so not sure how useful having another syslog is now.

If rsyslog is a different program, then it's useful to someone!

> ---
>  gnu/packages/syslog.scm | 110 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 110 insertions(+)
>  create mode 100644 gnu/packages/syslog.scm

For your revisions, please submit each package as its own patch. You can
read `git log` to learn the conventions for commit messages.

Also, please remember to run `./pre-inst-env guix lint` on each
package. Most of the changes that need to made to these packages will be
described by `guix lint`.

[...]

> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2013 Andreas Enge <address@hidden>
> +;;; Copyright © 2014, 2015 Mark H Weaver <address@hidden>

Don't forget to add a copyright line for yourself.

> +(define-public libfastjson

[...]

> +    (license license:gpl2+))) ; FIXME actually MIT. Which one?

In the links I shared above, refer to the Expat and X11 licenses to see
which "MIT" license this is.

> +(define-public liblogging

[...]

> +    (arguments `(#:configure-flags '("--disable-journal" ; to avoid 
> libsystemd-journal
> +)))

If you leave the journal support enabled, does the program break when
journald is absent? Users on systemd-based systems may want to use
liblogging :)

> +(define-public rsyslog

[...]

> +    (inputs `(("libestr"      ,libestr)
> +              ("libfastjson"  ,libfastjson)
> +              ("zlib"         ,zlib)
> +              ("util-linux"   ,util-linux)

Since util-linux is a "grab bag" of unrelated programs, I like to say in
what it's being used for. There are some examples of this in
gnu/packages.

Can you submit a revised patch set?