Re: [PATCH] Add GNOME and XFCE desktop services.

[Ludovic Courtès]

Andy Wingo <address@hidden> skribis:

> Greets :)
>
> On Thu 25 Feb 2016 03:40, address@hidden (宋文武) writes:
>
>>> @@ -717,6 +766,10 @@ when they log out."
>>>    ;; List of services typically useful for a "desktop" use case.
>>>    (cons* (slim-service)
>>>  
>>> +         ;; Polkit permissions for desktops to control brightness, etc.
>>> +         (gnome-desktop-service)
>>> +         (xfce-desktop-service)
>>> +
>>>           ;; Screen lockers are a pretty useful thing and these are small.
>>>           (screen-locker-service slock)
>>>           (screen-locker-service xlockmore "xlock")
>> It’s confusing, these really are ‘gnome-settings-daemon-service’ and
>> ‘thunar-service’ to enable the polkit rules.  We would expect a
>> ‘gnome-desktop-service’ to bring a full GNOME environment, which can
>> be done by extend ‘profile-service-type’ with the ‘gnome’ meta-package.
>> But then the configuable ‘gnome-settings-daemon’ package is duplicate,
>> roughly speaking we could extracted it from the ‘propagated-inputs’ of
>> the ‘gnome’ package, which isn’t a straight way…
>
> I can see how that can be confusing, thanks for the feedback.

It’s OK if ‘gnome-settings-daemon’ appears twice in the global profile.
Or we can modify the ‘gnome’ meta-package to not depend on it?

But yeah, I agree that full-blown ‘gnome-desktop-service’ and
‘xfce-desktop-service’, which also extend ‘profile-service-type’, would
be nicer.

However, ‘%desktop-services’ should probably include none of them by
default.

> I think Mark has expressed a preference that packages should not add to
> services by default: the reason being that you (as a user, as a Guix
> developer, patch reviewer, etc) don't really have to trust a package,
> whereas services grant special privileges and thus need more scrutiny.
> With this in mind, I don't see how to extract GNOME services from a
> (meta-)package.
>
> What do you think is the right solution in the short term?  Rename these
> services to reflect their package name?

Currently SLiM takes .desktop files that it finds at run time, which it
not so great for the reasons you give above.

The solution will probably be to to have the hypothetical
‘gnome-desktop’ and ‘xfce-desktop’ service extend it via the service
extension mechanism.

Anyway, thanks for the thorough investigation, sounds like we’re on the
right track!  :-)

Ludo’.