Re: [PATCH 12/18] gnu: Add python-anyjson.

[Christopher Allan Webber]

Leo Famulari writes:

> On Fri, Feb 19, 2016 at 06:34:39PM -0800, Christopher Allan Webber wrote:
>> Updated.
>> 
>
>> From be98d30d19451a7676a178f017f97173c5d6d29c Mon Sep 17 00:00:00 2001
>> From: Christopher Allan Webber <address@hidden>
>> Date: Sun, 14 Feb 2016 12:16:49 -0800
>> Subject: [PATCH 11/18] gnu: Add python-anyjson.
>> 
>> * gnu/packages/python.scm (python-anyjson, python2-anyjson): New variables.
>> ---
>>  gnu/packages/python.scm | 39 +++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 39 insertions(+)
>> 
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 65bf70d..7ce4f09 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -7857,3 +7857,42 @@ minimum of WSGI.")
>>        (inherit webtest)
>>        (native-inputs `(("python2-setuptools" ,python2-setuptools)
>>                         ,@(package-native-inputs webtest))))))
>> +
>> +(define-public python-anyjson
>> +  (package
>> +    (name "python-anyjson")
>> +    (version "0.3.3")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "anyjson" version))
>> +       (sha256
>> +        (base32
>> +         "1fjph4alvcscsl5d4b6qpv1yh31jy05jxi1l0xff7lws7j32v09p"))))
>> +    (build-system python-build-system)
>> +    (arguments
>> +     `(;; We could possibly get tests working, but on Python 3 it's not so 
>> easy.
>> +       ;; Very strangely, 2to3 is run *during setup.py install* (or bdist, 
>> or
>> +       ;; whatever) so this transformation needs to be done before the tests
>> +       ;; can be run.  Maybe we could add a build step to transform 
>> beforehand
>> +       ;; but it could be annoying/difficult.
>> +       ;; We can enable tests for the Python 2 version, though, and do 
>> below.
>> +       #:tests? #f))
>> +    (home-page "http://bitbucket.org/runeh/anyjson/";)
>> +    (synopsis
>> +     "Wraps best available JSON implementation in a common interface")
>> +    (description
>> +     "Anyjson loads whichever is the fastest JSON module installed
>> +and provides a uniform API regardless of which JSON implementation is 
>> used.")
>> +    (license bsd-3)
>> +    (properties `((python2-variant . ,(delay python2-anyjson))))))
>> +
>> +(define-public python2-anyjson
>> +  (package
>> +    (inherit (package-with-python2
>> +              (strip-python2-variant python-anyjson)))
>> +    (arguments `(;; Unlike the python 3 variant, we do run tests.  See 
>> above!
>> +                 #:tests? #t
>> +                 #:python ,python-2))
>
> How about referring to the package-arguments of python-anyjson, like you
> did in python2-amqp, rather than specifying the python-version? Or does
> that not work?

Good idea.  Will push with that change when I push the rest (hopefully)
tonight.