Re: [PATCH 6/18] gnu: Add python-beautifulsoup4

[Christopher Allan Webber]

Leo Famulari writes:

>> +;; beautifulsoup4 has a totally different namespace than 3.x,
>> +;; and pypi seems to put it under its own name, so I guess we should too
>> +(define-public python-beautifulsoup4
>> +  (package
>> +    (name "python-beautifulsoup4")
>> +    (version "4.4.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "beautifulsoup4" version))
>> +       (sha256
>> +        (base32
>> +         "1d36lc4pfkvl74fmzdib2nqnvknm0jddgf2n9yd7im150qyh3m47"))))
>> +    (build-system python-build-system)
>> +    (inputs
>> +     `(("python-lxml" ,python-lxml)
>> +       ("python-html5lib" ,python-html5lib)))
>
> I didn't find these necessary for the build process and test suite. Are
> you sure they aren't supposed to be provided by the application that
> uses beautifulsoup4?

I think you're right in that they're optional, and can be provided or
not with the application that uses it.  I removed them.

>> +    (home-page
>> +     "http://www.crummy.com/software/BeautifulSoup/bs4/";)
>> +    (synopsis
>> +     "Python screen-scraping library")
>> +    (description
>> +     "HTML/XML parser for quick-turnaround applications like 
>> screen-scraping.
>> +Can parse even extremely broken HTML.")
>
> How about this:
>
> "Beautiful Soup is a Python library designed for rapidly setting up
> screen-scraping projects.  It offers Pythonic idioms for navigating,
> searching, and modifying a parse tree, providing a toolkit for
> dissecting a document and extracting what you need.  It automatically
> converts incoming documents to Unicode and outgoing documents to UTF-8."

That's much better, thanks!

>> +    (license bsd-3)
>
> It uses the Expat license, and has some code from html5lib, which is
> also Expat.

Eep, thanks for the catch.

>> +    (properties `((python2-variant . ,(delay python2-beautifulsoup4))))))
>> +
>> +(define-public python2-beautifulsoup4
>> +  (package
>> +    (inherit (package-with-python2
>> +              (strip-python2-variant python-beautifulsoup4)))
>> +    (inputs `(("python2-setuptools" ,python2-setuptools)))))
>> +
>>  (define-public python2-pil
>>    (package
>>      (name "python2-pil")
>> -- 
>> 2.6.3
>> 
>> 

New patch of this and a bunch of others with these fixes coming as soon
as I finish churning through all this feedback ;)