guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: Add vcsh


From: Leo Famulari
Subject: Re: [PATCH 3/3] gnu: Add vcsh
Date: Sat, 13 Feb 2016 17:41:08 -0500
User-agent: Mutt/1.5.24 (2015-08-30)

On Sat, Feb 13, 2016 at 04:07:55PM +0000, Christopher Baines wrote:
> * gnu/packages/version-control.scm (vcsh): New variable.

[...]

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (delete 'configure)
> +                  (delete 'check)
> +                  (delete 'build))

Can you add comments explaining why the check and build phases are
deleted?

For the former, it can be as simple as "no test suite".

I assume the build phase is replaced by the install phase; the comment
can say something like that if it's the case.

> +       #:make-flags (list (string-append "PREFIX=" %output))))
> +    (native-inputs
> +     `(("which" ,which)))
> +    (inputs
> +     `(("perl-shell-command" ,perl-shell-command)
> +       ("perl-test-most" ,perl-test-most)))
> +    (propagated-inputs
> +     `(("git" ,git)))
> +    (home-page "https://github.com/RichiH/vcsh";)
> +    (synopsis "Version control system for $HOME")
> +    (description
> +     "vcsh provides the @code{vcsh} command, which allows you to maintain
> +several Git repositories in one single directory.  This can be useful when
> +using version control for files in your home directory, as it allows for
> +the separation of the files in to different repositories, for example you
> +may keep your bash configuration in a separate Git repository from your
> +emacs configuration.")
> +    (license gpl2+)))
> -- 
> 2.7.0
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]