Re: [PATCH] gnu: Add notmuch-addrlookup-c.

[Leo Famulari]

On Tue, Feb 09, 2016 at 11:51:05PM -0800, Al McElrath wrote:
> 
> Hello,
> 
> First package here. Please advise.

Thanks for the patch!

> From 6db39ac748414cd91c9dd2ab1c2379fdca15e41d Mon Sep 17 00:00:00 2001
> From: Al McElrath <address@hidden>
> Date: Tue, 9 Feb 2016 12:07:30 -0800
> Subject: [PATCH] gnu: Add notmuch-addrlookup-c.
> 
> * gnu/packages/mail.scm (notmuch-addrlookup-c): New variable.

[...]

> +    (version "v7")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/aperezdc/"; name "/archive/"
> +                    version ".tar.gz"))

GitHub automatically creates these "v*" version identifiers, but in this
case, upstream's changelog describes the version as "7", so let's use
that, and adjust the URI accordingly.

You'll also need to set the file-name of the downloaded source, as done
in commit f1957fc145.  Otherwise the tarball's name does not include the
package name. (This is noticed by the linter).

> +              (sha256
> +               (base32
> +                "0rslg2ifgyhl6asv3yr1f62m9xjfcinv7i6qb07h2k217jqlmrri"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f ;; no tests

This comment can use one ';'.
https://www.gnu.org/software/guile/manual/html_node/Comments.html

> +       #:make-flags (list "CC=gcc"
> +                          (string-append "PREFIX="
> +                                         (assoc-ref %outputs "out")))
> +       #:phases (modify-phases %standard-phases
> +                  (delete 'configure)
> +                  (add-before 'patch-source-shebangs 'delete-ycm-file
> +                              (lambda _ (delete-file ".ycm_extra_conf.py")))

Can you add a brief comment explaining this deletion?

> +                  (replace 'install
> +                           (lambda* (#:key outputs #:allow-other-keys)
> +                             (let ((bin (string-append
> +                                         (assoc-ref outputs "out") "/bin/"))
> +                                   (na "notmuch-addrlookup"))
> +                               (mkdir-p bin)
> +                               (copy-file na (string-append bin na))))))))

We have a procedure install-file that combines mkdir-p and copy-file.
Can you use that?

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("glib" ,glib)
> +       ("notmuch" ,notmuch)))
> +    (home-page "https://github.com/aperezdc/notmuch-addrlookup-c";)
> +    (synopsis "Address lookup tool for Notmuch in C")

I don't think it's necessary to mention the language of implementation.

> +    (description "This is an address lookup tool using a Notmuch database,
> +useful for email address completion in emacs.")

Similarly, I don't think it's necessary to mention that it can be used
with Emacs.

It looks good to me with these changes. Can you submit a revised patch?

> +    (license license:expat)))
> +
>  (define-public python2-notmuch
>    (package
>      (name "python2-notmuch")
> -- 
> 2.5.0
>