guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add rubygems updater.


From: Ludovic Courtès
Subject: Re: [PATCH] Add rubygems updater.
Date: Fri, 01 Jan 2016 19:17:17 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ben Woodcroft <address@hidden> skribis:

> On 01/01/16 19:28, Pjotr Prins wrote:
>> On Fri, Jan 01, 2016 at 06:27:21PM +1000, Ben Woodcroft wrote:
>>> It seems there's 30 packages to be updated, out of the 107 in
>>> ruby.scm. Going through each of these individually seems a little
>>> tedious, can we do them in bulk somehow or do they have to be
>>> committed individually? Building and testing all packages that
>>> require these packages would be a start - is there any way to list
>>> all dependent packages?
>>>
>>> gnu/packages/ruby.scm:2807:13: ruby-cutest would be upgraded from
>>> 1.2.2 to 1.2.3
>>> gnu/packages/ruby.scm:333:13: ruby-rspec-mocks would be upgraded
>>> from 3.2.1 to 3.4.0
>> (etc)
>>
>> I don't think it is a good idea to automatically update
>> packages. Reason being that packages should be updated by someone who
>> is actively using that new version. Automated tests are one thing,
>> real user feedback another. Not to mention that many gems don't have
>> tests ;).
> I think we should update the package definitions so that more have
> tests, and failing that import the library so we know it can at least
> be loaded, like this:
>
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (zero? (system* "ruby" "-Ilib" "-r" "ansi")))))))

The only case where this would make a difference is for leaf packages,
no?  In all the other cases, building dependent packages will ensure
that the package at hand works as expected.

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]