Re: [PATCH 6/6] gnu: Add emacs-slime.

[Alex Kost]

Federico Beffa (2015-12-30 20:33 +0300) wrote:

[...]
> +(define-public emacs-slime
> +  (package
> +    (name "emacs-slime")
> +    (version "2.15")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/slime/slime/archive/v";
> +             version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0l2z6l2xm78mhh0nczkrmzh2ddb1n911ij9xb6q40zwvx4f8blds"))))
> +    (build-system emacs-build-system)
> +    (inputs
> +     `(("texlive" ,texlive)
> +       ("texinfo" ,texinfo)))

As these inputs are used just for generating documentation, I think they
should be in 'native-inputs'.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'install 'configure
> +           (lambda* _
> +             (substitute* "slime.el"
> +               (("inferior-lisp-program \"lisp\"")
> +                "inferior-lisp-program \"sbcl\""))
> +             #t))

Why do you name this phase 'configure'?  Actually I think this phase is
not needed, because 'inferior-lisp-program' should be set by a user to
whatever implementation (s)he prefers.

Thanks for packaging slime!

-- 
Alex