Re: [PATCH]: xfce4-power-manager: new variable

[Leo Famulari]

On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote:
> Hi,
> 
> attached is a patch for a first stab at packaging xfce4-power-manager. Since
> I used a different package as a base for this one there might be some
> unneeded inputs. I wonder if you guys have a tip for creating a little
> scheme snippet that would try all combinations of inputs to determine the
> minimal set for which ones the package build still succeeds? ;) [lazy flo]

The potential issue with this approach is that a lot of software will
build successfully even if some dependencies are missing. And then it
will fail at runtime, sometimes only in certain scenarios. Not that I
haven't thought about doing the same thing... :)

Ideally each program would have a test suite that exercised every code
path. Maybe AFL would be useful there? That sounds expensive but for
very complex systems, it would be worth it, because in my limited
experience packaging software, I have found that many upstream
developers are not aware of the dependency graph of their software. It's
fun to send them the output of "guix graph".

> 
> From 5ca12ed7fd62792b856aa686e66dfc224e16bf35 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <address@hidden>
> Date: Thu, 3 Dec 2015 14:57:10 +0100
> Subject: [PATCH] xfce4-power-manager: new variable
> 
> ---
>  gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index e213fb6..41e193a 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -646,6 +646,43 @@ menubar and the window decorations are hidden) that
> helps you to save space
>  on your desktop.")
>      (license gpl2+)))
> 
> +(define-public xfce4-power-manager
> +  (package
> +    (name "xfce4-power-manager")
> +    (version "1.4.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12";
> +                                  "/src/" name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> + "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:configure-flags '("--enable-gtk3")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("intltool" ,intltool)))
> +    (inputs
> +     `(("exo" ,exo)
> +       ("garcon", garcon)
> +       ("lbxrandr" ,libxrandr)
> +       ("libwnck" ,libwnck-1)
> +       ("upower" ,upower)
> +       ("libnotify" ,libnotify)
> +       ("libxfce4ui" ,libxfce4ui)))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "X_XFCE4_LIB_DIRS")
> +            (files '("lib/xfce4")))))
> +    (home-page "http://www.xfce.org/";)
> +    (synopsis "Xfce Power Manager")
> +    (description
> +     "Power manager daemon for Xfce and associated settings page.
> +Controls backlight, power saving, etc.")
> +    ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
> +    (license (list gpl2+ lgpl2.1+))))
> +
>  (define-public xfce
>    (package
>      (name "xfce")
> @@ -689,6 +726,7 @@ on your desktop.")
>         ("xfce4-session"        ,xfce4-session)
>         ("xfce4-settings"       ,xfce4-settings)
>         ("xfce4-terminal"       ,xfce4-terminal)
> +       ("xfce4-power-manager"  ,xfce4-power-manager)
>         ("xfconf"               ,xfconf)
>         ("xfdesktop"            ,xfdesktop)
>         ("xfwm4"                ,xfwm4)
> -- 
> 2.5.0
> 
> 
> Flo
> 
> 
> 

> From 5ca12ed7fd62792b856aa686e66dfc224e16bf35 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <address@hidden>
> Date: Thu, 3 Dec 2015 14:57:10 +0100
> Subject: [PATCH] xfce4-power-manager: new variable
> 
> ---
>  gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index e213fb6..41e193a 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -646,6 +646,43 @@ menubar and the window decorations are hidden) that 
> helps you to save space
>  on your desktop.")
>      (license gpl2+)))
>  
> +(define-public xfce4-power-manager
> +  (package
> +    (name "xfce4-power-manager")
> +    (version "1.4.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12";
> +                                  "/src/" name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:configure-flags '("--enable-gtk3")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("intltool" ,intltool)))
> +    (inputs
> +     `(("exo" ,exo)
> +       ("garcon", garcon)
> +       ("lbxrandr" ,libxrandr)
> +       ("libwnck" ,libwnck-1)
> +       ("upower" ,upower)
> +       ("libnotify" ,libnotify)
> +       ("libxfce4ui" ,libxfce4ui)))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "X_XFCE4_LIB_DIRS")
> +            (files '("lib/xfce4")))))
> +    (home-page "http://www.xfce.org/";)
> +    (synopsis "Xfce Power Manager")
> +    (description
> +     "Power manager daemon for Xfce and associated settings page. 
> +Controls backlight, power saving, etc.")
> +    ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
> +    (license (list gpl2+ lgpl2.1+))))
> +
>  (define-public xfce
>    (package
>      (name "xfce")
> @@ -689,6 +726,7 @@ on your desktop.")
>         ("xfce4-session"        ,xfce4-session)
>         ("xfce4-settings"       ,xfce4-settings)
>         ("xfce4-terminal"       ,xfce4-terminal)
> +       ("xfce4-power-manager"  ,xfce4-power-manager)
>         ("xfconf"               ,xfconf)
>         ("xfdesktop"            ,xfdesktop)
>         ("xfwm4"                ,xfwm4)
> -- 
> 2.5.0
>