[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] gnu: Add evolution-data-server.
From: |
Alex Kost |
Subject: |
Re: [PATCH 2/5] gnu: Add evolution-data-server. |
Date: |
Tue, 10 Nov 2015 19:57:37 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
宋文武 (2015-11-10 15:51 +0300) wrote:
[...]
> +(define-public evolution-data-server
> + (package
> + (name "evolution-data-server")
> + (version "3.18.2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnome/sources/" name "/"
> + (version-major+minor version) "/"
> + name "-" version ".tar.xz"))
> + (sha256
> + (base32
> + "16yfd2a00xqxikyf6pi2awfd0qfq4hwdhfar88axrb4mycfgqhjr"))))
> + (build-system gnu-build-system)
> + (arguments
> + '(;; XXX: fails with:
> + ;; /Fixture/Calendar0: cleaning up pid xxxx
> + ;; t status: 139)
> + #:tests? #f
> + #:configure-flags
> + (let ((nss (assoc-ref %build-inputs "nss"))
> + (nspr (assoc-ref %build-inputs "nspr")))
> + (list "--disable-uoa" ; disable Ubuntu Online Accounts support
> + "--disable-google" ; disable Google Contacts support
> + (string-append "--with-nspr-includes=" nspr "/include/nspr")
> + (string-append "--with-nss-includes=" nss "/include/nss")
> + (string-append "--with-nss-libs=" nss "/lib/nss")))
^^
Please indent (string-append ...) clauses inside list properly.
> + #:phases
> + (modify-phases %standard-phases
> + (add-before
> + 'check 'pre-check
> + (lambda _
> + (substitute* "tests/test-server-utils/e-test-server-utils.c"
I would make it:
(add-before 'check 'pre-check
(lambda _
(substitute* "tests/test-server-utils/e-test-server-utils.c"
but it probably doesn't matter.
> + (("/bin/rm") (which "rm")))
> + #t)))))
> + (native-inputs
> + `(("glib:bin" ,glib "bin") ; for glib-mkenums, etc.
> + ("gobject-introspection" ,gobject-introspection)
> + ("gperf" ,gperf)
> + ("intltool" ,intltool)
> + ("pkg-config" ,pkg-config)
> + ("python" ,python)))
> + (propagated-inputs
> + ;; These are all in the Requires field of .pc files.
> + `(("gtk+" ,gtk+)
> + ("libical" ,libical)
> + ("libsecret" ,libsecret)
> + ("libsoup" ,libsoup)
> + ("nss" ,nss)
> + ("sqlite" ,sqlite)))
> + (inputs
> + `(("bdb" ,bdb)
> + ("gcr" ,gcr)
> + ("gnome-online-accounts" ,gnome-online-accounts)
> + ("libgweather" ,libgweather)))
> + (synopsis "Libraries and services for storing addressbooks and
> calendars")
I think it's better to use "address books".
--
Alex
- [PATCH 1/5] gnu: Add gnome-online-accounts., 宋文武, 2015/11/10
- [PATCH 3/5] gnu: Add caribou., 宋文武, 2015/11/10
- [PATCH 2/5] gnu: Add evolution-data-server., 宋文武, 2015/11/10
- Re: [PATCH 2/5] gnu: Add evolution-data-server.,
Alex Kost <=
- [PATCH 4/5] gnu: Add gdm., 宋文武, 2015/11/10
- Re: [PATCH 1/5] gnu: Add gnome-online-accounts., Ludovic Courtès, 2015/11/11