[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/15] scripts: system: Add 'container' action.
From: |
Thompson, David |
Subject: |
Re: [PATCH 13/15] scripts: system: Add 'container' action. |
Date: |
Fri, 30 Oct 2015 13:28:38 -0400 |
On Tue, Oct 27, 2015 at 1:41 PM, Ludovic Courtès <address@hidden> wrote:
> "Thompson, David" <address@hidden> skribis:
>
>> From 5dde31ef51502726a2915cc4faba81f4fadb851c Mon Sep 17 00:00:00 2001
>> From: David Thompson <address@hidden>
>> Date: Mon, 8 Jun 2015 09:04:38 -0400
>> Subject: [PATCH] scripts: system: Add 'container' action.
>>
>> * guix/scripts/system.scm (show-help): Display 'container' action.
>> (system-derivation-for-action, guix-system): Add 'container' case.
>> (perform-action): Skip GRUB config generation when building a container.
>> * doc/guix.texi (Invoking guix system): Document it.
>
> [...]
>
>> + ;; A range of 65536 uid/gids is used to cover 16 bits worth of
>> + ;; users and groups, which is sufficient for most cases.
>
> Should be enough for everyone. ;-)
Hehe. I need to do more research on this. User/group mapping is
still pretty confusing to me.
>> (display (_ "\
>> + container build a Linux container that shares the host's
>> store\n"))
>
> I’d remove “Linux” here (after all, we use libc’s interface, which
> hopefully will be implemented for the Hurd eventually.)
Fixed and pushed. Thanks!
- Dave