[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] GCJ: run libjava tests.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] GCJ: run libjava tests. |
Date: |
Tue, 27 Oct 2015 13:28:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> Attached is a new patch that pulls the ‘#:test-target’ line out of the
> ‘substitute-keyword-arguments’ expression. The indentation of many
> lines changes because of this. ‘git diff -w’ shows that the actual
> change is pretty small.
[...]
> + `(#:test-target "check-target-libjava"
> + ,@(substitute-keyword-arguments `(#:modules ((guix build
> gnu-build-system)
> + (guix build utils)
> + (ice-9 regex)
> + (srfi srfi-1)
> + (srfi srfi-26))
> + ,@(package-arguments gcc))
#:test-target could even go after #:modules in the argument to
‘substitute-keyword-arguments’, for consistency.
Otherwise LGTM.
Thanks!
Ludo’.
- [PATCH] GCJ: run libjava tests., Ricardo Wurmus, 2015/10/22
- Re: [PATCH] GCJ: run libjava tests., Andreas Enge, 2015/10/22
- Re: [PATCH] GCJ: run libjava tests., Ricardo Wurmus, 2015/10/22
- Re: [PATCH] GCJ: run libjava tests., Ricardo Wurmus, 2015/10/22
- Re: [PATCH] GCJ: run libjava tests., Andreas Enge, 2015/10/23
- Re: [PATCH] GCJ: run libjava tests., Ludovic Courtès, 2015/10/25
- Re: [PATCH] GCJ: run libjava tests., Ricardo Wurmus, 2015/10/27
- Re: [PATCH] GCJ: run libjava tests.,
Ludovic Courtès <=
- Re: [PATCH] GCJ: run libjava tests., Ricardo Wurmus, 2015/10/27