[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] gnu: Add cmus.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH 3/3] gnu: Add cmus. |
Date: |
Thu, 22 Oct 2015 08:41:18 +0200 |
User-agent: |
mu4e 0.9.13; emacs 24.5.1 |
Hi Paul,
> * gnu/packages/music.scm (cmus): New variable.
> ---
> gnu/packages/music.scm | 65
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
[...]
> +(define-public cmus
> + (package
> + (name "cmus")
> + (version "2.7.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/" name "/" name "/archive/v"
> + version ".tar.gz"))
Please use ‘(file-name ...)’ here as the tarball is only named
‘v2.7.1.tar.gz’.
> + (sha256
> + (base32
> + "0raixgjavkm7hxppzsc5zqbfbh2bhjcmbiplhnsxsmyj8flafyc1"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests?
> + #f ; cmus does not include tests
Putting the ‘#f’ on a separate line looks odd. Please put ‘#:tests? #f’
on one line together with the margin comment.
[...]
> + ("pkg-config" ,pkg-config)
This should be in native-inputs instead.
> + ("pulseaudio" ,pulseaudio)
> + ("wavpack" ,wavpack)))
> + (home-page "https://cmus.github.io/")
> + (synopsis "Small, fast and powerful console music player")
> + (description "Cmus is a small, fast and powerful console music player
> for
> +Unix-like operating systems.")
“for Unix-like operating systems” seems redundant as Guix only works on
GNU systems.
> + (license license:gpl2+)))
> +
> (define-public hydrogen
> (package
> (name "hydrogen")
~~ Ricardo