guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add cabal-install.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add cabal-install.
Date: Fri, 28 Aug 2015 11:00:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Siniša Biđin <address@hidden> skribis:

> On 2015-08-25 23:27, address@hidden wrote:

[...]

>>> +    (arguments `(#:tests? #f))
>>
>> Could you add a comment above explaining why tests are disabled?  (We
>> generally avoid that unless there’s a good reason, sometimes because
>> running the tests would be unnecessarily complex.)
>
> I've added a simple "FIXME" comment to that line, similar to how the
> other haskell.scm packages do it. The reason is that the ghc-* libs
> needed to enable testing haven't been imported yet. I've attempted to
> fix that, but got tangled up in conflicting dependency versions and
> gave up for now.

Fair enough.

> Sure, you'll find it attached.

Applied, thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]