Re: [PATCH 1/2] gnu: itstool: Wrap with PTYHONPATH.

[宋文武]

Mark H Weaver <address@hidden> writes:

> 宋文武 <address@hidden> writes:
>
>> gnu: itstool: Wrap with PTYHONPATH.
>
> s/PTYHONPATH/PYTHONPATH/
oops, thanks!
>
>> * gnu/packages/glib.scm (itstool): Change 'propagated-inputs' to 'inputs'.
>>   [arguments]: New field.
>> ---
>>  gnu/packages/glib.scm | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
>> index 88c61b6..59d64e9 100644
>> --- a/gnu/packages/glib.scm
>> +++ b/gnu/packages/glib.scm
>> @@ -315,10 +315,18 @@ The intltool collection can be used to do these things:
>>                (base32
>>                 "0fh34wi52i0qikgvlmrcpf1vx6gc1xqdad4539l4d9hikfsrz45z"))))
>>      (build-system gnu-build-system)
>> -    (propagated-inputs
>> +    (inputs
>>       `(("libxml2" ,libxml2)
>>         ("python2-libxml2" ,python2-libxml2)
>>         ("python-2" ,python-2)))
>> +    (arguments
>> +     '(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after
>> +          'install 'wrap-program
>> +          (lambda _
>> +            (wrap-program (string-append %output "/bin/itstool")
>
> In phase procedures, it's probably better to accept the 'outputs'
> keyword argument to the phase procedure and use that.
ok.
>
>> +              `("PYTHONPATH" = (,(getenv "PYTHONPATH")))))))))
>>      (home-page "http://www.itstool.org";)
>>      (synopsis "Tool to translate XML documents with PO files")
>>      (description
>
> Otherwise it looks good to me.
Pushed, thanks for review!