guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xscreenshot and imagefile


From: Mark H Weaver
Subject: Re: [PATCH] xscreenshot and imagefile
Date: Thu, 30 Jul 2015 21:51:05 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Mark H Weaver <address@hidden> writes:
> Do other people think that such programs belong in Guix?

Okay, it seems that the general feeling is that we should accept these
programs, so I'll go along with that.  I guess I should apologize for
making you feel unwelcome.  My social skills leave much to be desired.

Anyway, the remaining issues to resolve are:

* You should add your copyright notice to suckless.scm.

* The version numbers should not be 1.0 unless there is either a tarball
  release or a tag in the git repo that marks this commit as being
  version 1.0.  If there are no tarball releases and no tags, then the
  version strings should probably be of the form "YYYYMMDD.<commit>".
  Putting the date in front is important so that version numbers can be
  compared correctly by the "guix package -u" command.

* As Alex pointed out, the license on 'xscreenshot' is actually the
  expat license, not the X11 license, so the license field needs to be
  fixed.

* As Alex pointed out, the description lines should be wrapped to keep
  the sources within 80 columns.

Would you like to send updated patches?

     Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]