guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: colord: Propagate inputs.


From: Mark H Weaver
Subject: Re: [PATCH 3/3] gnu: colord: Propagate inputs.
Date: Sat, 25 Jul 2015 19:21:32 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

宋文武 <address@hidden> writes:

> * gnu/packages/gnome.scm (colord): Propagate inputs glib, eudev and lcms.
> ---
>  gnu/packages/gnome.scm | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 11afb61..738047e 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -2181,11 +2181,14 @@ keyboard shortcuts.")
>         ("gobject-introspection" ,gobject-introspection)
>         ("libtool" ,libtool)
>         ("intltool" ,intltool)))
> +    (propagated-inputs
> +     ;; colord.pc refers to all these.
> +     `(("glib" ,glib)
> +       ("libudev" ,eudev)

I suppose it doesn't matter, but normally for 'eudev' we make the key
string "udev".  Or did you mean to use 'libgudev' here?

> +       ("lcms" ,lcms)))
>      (inputs
> -     `(("eudev" ,eudev)
> -       ("dbus-glib" ,dbus-glib)
> +     `(("dbus-glib" ,dbus-glib)
>         ("libusb" ,libusb)
> -       ("lcms" ,lcms)
>         ("sqlite" ,sqlite)
>         ("polkit" ,polkit)
>         ("sane-backends" ,sane-backends)))

Anyway, I'll trust your judgment here.  Please push as you see fit.

   Thank you!
      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]