[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add rpy2.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] Add rpy2. |
Date: |
Mon, 20 Jul 2015 11:51:46 +0200 |
Ludovic Courtès <address@hidden> writes:
> Ricardo Wurmus <address@hidden> skribis:
>
>> From 070b4f5553ae30c05b97a67692b54503c73ca42f Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <address@hidden>
>> Date: Tue, 7 Jul 2015 13:56:49 +0200
>> Subject: [PATCH] gnu: Add python-rpy2.
>>
>> * gnu/packages/python.scm (python-rpy2, python2-rpy2): New variables.
>
> [...]
>
>> + (inputs
>> + `(("python-six" ,python-six)
>> + ("readline" ,readline)
>> + ("icu4c" ,icu4c)
>> + ("pcre" ,pcre)))
>> + (native-inputs
>> + `(("python-setuptools" ,python-setuptools)
>> + ("r" ,r)))
>
> I think R is used for its libraries, so it should be in ‘inputs’ in
> theory.
>
>> + (license gpl2+)))
>
> R being GPLv3+, this should be the same.
>
> OK with these changes!
Thanks for the review. I pushed it with the suggested changes.
~~ Ricardo