Re: [PATCH 3/3] gnu: Add python-pelican

[Ludovic Courtès]

Christopher Allan Webber <address@hidden> skribis:

> From 220db75dbf4700a8c9b342cf68dacce74d864d8a Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <address@hidden>
> Date: Fri, 10 Jul 2015 16:28:01 -0500
> Subject: [PATCH 3/3] gnu: Add python-pelican
>
> * gnu/packages/python.scm (python-pelican): New variables.

[...]

> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)

Move this one to ‘native-inputs’.

> +       ("python-feedgenerator" ,python-feedgenerator)
> +       ("python-jinja2" ,python-jinja2)
> +       ("python-pygments" ,python-pygments)
> +       ("python-docutils" ,python-docutils)
> +       ("python-pytz" ,python-pytz)
> +       ("python-blinker" ,python-blinker)
> +       ("python-unidecode" ,python-unidecode)
> +       ("python-six" ,python-six)
> +       ("python-dateutil-2" ,python-dateutil-2)))

If Pelican is simply meant to be used as a command-line tool, this is
fine.  Otherwise, if it’s meant as a Python library (or both), these
probably need to be moved to ‘propagated-inputs’.

> +    (arguments
> +     `(;; Requires a lot more packages to do unit tests :P
> +       #:tests? #f

Add “XXX” to make it more prominent.  :-)

> +    (synopsis
> +     "Python-based static site publishing system")

Keep it on a single line.

> +    (description
> +     "A tool to generate a static blog from reStructuredText, Markdown input 
> files,

“Pelican is a tool...”

> +    ;; No indication that this is "or later" in the source,
> +    ;; must assume AGPLv3 only
> +    (license agpl3)))

Unless the license version is explicitly specified somewhere, the
recipient can use any version of the license (per Section 14 of GPLv3),
which we’d translate it as ‘agpl3+’ here.

Could you send an updated patch?

TIA,
Ludo’.