[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system
From: |
Pjotr Prins |
Subject: |
Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system |
Date: |
Sun, 19 Jul 2015 11:29:41 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Jul 18, 2015 at 05:20:28PM +0200, Ludovic Courtès wrote:
> > (zero? (system* "gem" "install" "--local"
> > - "--bindir" (string-append out "/bin")))))
> > + "--bindir" (string-append out "/bin") "--"
> > + (string-join (cond (null?
> > gem-flags)('())(gem-flags)))))))
>
> , and ‘gem-flags’ is not a procedure so it cannot be called. So
> I’ve changed that, also removing the “--”. Pushed as 6e9f291.
The "--" is required when gem-flags is passed in. It is optional when
gem-flags is empty. Do you think gem authors should always prepend the
"--" in front of the other options? I would think it is a builder
thing if we can abstract it away. Right? If that is so, we can leave it
there since it is harmless if gem-flags is empty.
Pj.