[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/11] gnu: Add oslotest.
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH 02/11] gnu: Add oslotest. |
Date: |
Thu, 16 Jul 2015 13:10:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Hi,
I've not test it but I have some stylistic remarks :). Most of them apply
to other parts of your patch and to the other patches.
Cyril Roelandt <address@hidden> writes:
> +(define-public python-mox3
> + (package
> + (name "python-mox3")
^
It should be indent under the first 'a'.
> + (uri (string-append
> + "https://pypi.python.org/packages/source/m/mox3/mox3-"
> + version
> + ".tar.gz"))
^
In Emacs the indentation is made under the "s" of string-append, but what
about something more compact like this:
(uri (string-append "https://pypi.python.org/packages/source/m/"
"mox3/mox3-" version ".tar.gz"))
> + `(#:tests? #f)) ;; Circular dependency with python-oslotest
^^
only one ';' should be used for comments on the same line.
> +;; Packages from the Oslo library
> +(define-public python-oslotest
--8<---------------cut here---------------start------------->8---
;;;
;;; Packages from the Oslo library.
;;;
(define-public python-oslotest
--8<---------------cut here---------------end--------------->8---
> + ("python-six" ,python-six)))
> + (inputs
> + `(("python-pbr" ,python-pbr)
^^^
> + ("python-mox3" ,python-mox3)
> + ("python-os-client-config" ,python-os-client-config)
> + ("python-setuptools" ,python-setuptools)
> + ("python-subunit" ,python-subunit)
> + ("python-testrepository" ,python-testrepository)
> + ("python-testscenarios" ,python-testscenarios)
> + ("python-testtools" ,python-testtools)))
Since the rest is ordered lexicographically... :)
> + (home-page "http://github.com/ActiveState/appdirs")
> + (synopsis
> + "A small Python module for determining appropriate \" +
> \"platform-specific dirs, e.g. a \"user data dir\".")
> + (description
> + "A small Python module for determining appropriate \" +
> \"platform-specific dirs, e.g. a \"user data dir\".")
I guess this is something not intentional.
--
Mathieu Lirzin
- [PATCH 00/11] Add a few modules from the Oslo library., Cyril Roelandt, 2015/07/15
- [PATCH 01/11] gnu: Bump python-six to 1.9.0., Cyril Roelandt, 2015/07/15
- [PATCH 03/11] gnu: Add oslo.i18n., Cyril Roelandt, 2015/07/15
- [PATCH 02/11] gnu: Add oslotest., Cyril Roelandt, 2015/07/15
- Re: [PATCH 02/11] gnu: Add oslotest.,
Mathieu Lirzin <=
- Re: [PATCH 02/11] gnu: Add oslotest., Thompson, David, 2015/07/20
- Re: [PATCH 02/11] gnu: Add oslotest., Cyril Roelandt, 2015/07/22
- Re: [PATCH 02/11] gnu: Add oslotest., Ian Denhardt, 2015/07/22
- Re: [PATCH 02/11] gnu: Add oslotest., Thompson, David, 2015/07/22
- Re: [PATCH 02/11] gnu: Add oslotest., Ludovic Courtès, 2015/07/23
- Re: [PATCH 02/11] gnu: Add oslotest., Cyril Roelandt, 2015/07/23
- Re: [PATCH 02/11] gnu: Add oslotest., Thompson, David, 2015/07/23
[PATCH 04/11] gnu: Add oslo.config, Cyril Roelandt, 2015/07/15
[PATCH 05/11] gnu: Add oslo.utils., Cyril Roelandt, 2015/07/15