Re: [PATCH] gnu: bootstrap: Create a wrapper for guile to set the system load path

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> We currently use gnu/packages/patches/guile-relocatable.patch to set the
> system load path in the bootstrap guile.  However, that patch depends on
> /proc/self/exe which is not present on the Hurd.  Therefore, I came up
> with another approach in the attached patch.  After unpacking the
> bootstrap guile, we use it to create its own wrapper that sets the
> GUILE_SYSTEM_PATH and GUILE_SYSTEM_COMPILED_PATH environment variables.

That sounds nice!

> My only concern is that these variables will be present in the
> environment in any subprograms launched by the bootstrap guile, and so
> if the bootstrap guile ever tries to run a different version of guile,
> those variable settings may cause trouble.

Good point.  I think that happens when ‘guile-final’ gets built, but you
mentioned that it built perfectly, right?  But in that case it’s OK
because meta/uninstalled-env overrides GUILE_SYSTEM_* anyway.

> From 885997fec1f0a175279edbf56b86050731892148 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Wed, 8 Jul 2015 12:31:32 -0400
> Subject: [PATCH] gnu: bootstrap: Create a wrapper for guile to set the system
>  load path.
>
> * gnu/packages/bootstrap.scm (raw-build): After unpacking, use the bootstrap
>   guile to create its own wrapper that sets the guile system load path.

[...]

> +         (make-guile-wrapper
> +          '(begin

Could you add a comment above mentioning that this replaces the previous
non-portable option based on /proc/self/exe?

OK for core-updates.

Thanks for helping out with this!

Ludo’.