Re: [PATCH] gnu: Add gst-plugins-ugly

[Mark H Weaver]

David Hashe <address@hidden> writes:

>> +    (home-page "http://gstreamer.freedesktop.org/";;)
>
> There's an extraneous semicolon here,

I'm not sure where that semicolon came from, but it wasn't in the patch
that I posted here.

> but once I removed that everything worked fine and I was able to play
> mp3s without issue.

That's good.

> I've attached an updated rhythmbox patch adding gst-plugins-ugly as a
> dependency along with some useful configure flags.

I don't think we should add optional plugins as propagated-inputs to all
programs that might use plugins.  Instead, each user should decide which
plugins to install in their profile, based on what formats they wish to
support.

   (propagated-inputs
    `(("dconf" ,dconf)
      ("gobject-introspection" ,gobject-introspection)
      ("gst-libav" ,gst-libav)
      ("gst-plugins-base" ,gst-plugins-base)
      ("gst-plugins-good" ,gst-plugins-good)
      ("gst-plugins-ugly" ,gst-plugins-ugly)
      ("totem-pl-parser" ,totem-pl-parser)))

I wonder about all of those propagated-inputs.  At the very least,
gst-libav and gst-plugins-{good,ugly} should be removed.  I wonder if
the others really need to be propagated-inputs.  This is a thorny
question, I confess, and we're still trying to hash it out in another
thread entitled "How to handle required plugins and dbus services for
GNOME Programs?"

     Mark