Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

[Mark H Weaver]

Alex Kost <address@hidden> writes:

> Mark H Weaver (2015-07-07 21:36 +0300) wrote:
>
>> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
>> index 82e8c88..6cdc846 100644
>> --- a/gnu/packages/pdf.scm
>> +++ b/gnu/packages/pdf.scm
>> @@ -172,8 +172,9 @@
>>      (build-system gnu-build-system)
>>      (arguments
>>       `(#:make-flags
>> -       `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> -          "PLUGINDIR=/lib/zathura" "CC=gcc")
>> +       `(,(string-append "PREFIX=" %output)
>> +         ,(string-append "PLUGINDIR=" %output "/lib/zathura")
>> +         "CC=gcc")
>
> As you change the whole clause anyway, wouldn't it be more good-looking
> to remove those "`" / "," and just use "list" instead?:
>
>           (list (string-append "PREFIX=" %output)
>                 (string-append "PLUGINDIR=" %output "/lib/zathura")
>                 "CC=gcc")

Agreed.  Pushed with this change.

    Thanks!
      Mark