Re: [PATCH] gnu: make-bootstrap: Produce the correct %glibc-bootstrap-tarball for Hurd systems.

[Ludovic Courtès]

Manolis Ragkousis <address@hidden> skribis:

> * gnu/packages/make-bootstrap.scm (%glibc-bootstrap-tarball): Make it a 
> procedure.
>   (%glibc-stripped): Make it a procedure and move the kernel specific part 
> from
>   here to ...
> * guix/build/make-bootstrap.scm (make-stripped-libc): ... here. New file.
>
> Co-authored-by: Ludovic Courtès <address@hidden>

[...]

> +(define-module (guix build make-bootstrap)
> +  #:use-module (srfi srfi-1)
> +  #:use-module (srfi srfi-11)
> +  #:use-module (srfi srfi-19)
> +  #:use-module (srfi srfi-26)
> +  #:use-module (guix build utils)
> +  #:export (make-stripped-libc))

Please add a comment like:

;;; Commentary:
;;;
;;; This module provides facilities to build the bootstrap binaries.
;;;
;;; Code:

> +(define (make-stripped-libc output libc kernel-headers)
> +  "Copy to OUTPUT the subset of LIBC and KERNEL-HEADERS that is needed
> +  when producing a bootstrap libc."
   ^
extra space

Make sure to add this new file to Makefile.am.

Otherwise LGTM.

Could you make sure that ‘guix build glibc-stripped-tarball’ still works
as expected?  (I assume you already tested with --target=i586-pc-gnu.)

If that passes, OK to commit to ‘master’ with the above changes.

Thanks!

Ludo’.