Re: [PATCH] Replace ATLAS with OpenBLAS (+lapack)

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> attached are three more patches to replace ATLAS with OpenBLAS in
> python.scm.

Good!

> From aeb4f541486d5bb02d4002380e8f7be49967b10d Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 12 Jun 2015 10:48:58 +0200
> Subject: [PATCH 1/3] gnu: python-numpy-bootstrap: Add lapack to inputs.
>
> * gnu/packages/python.scm (python-numpy-bootstrap)[inputs]: Add lapack to
>   inputs, because OpenBLAS does not include lapack functions.

OK.

> From a26127d8ecd9170d11350f7085c9e39aa4018b4a Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 12 Jun 2015 11:30:51 +0200
> Subject: [PATCH 2/3] gnu: python-scipy: Build with OpenBLAS and lapack.
>
> * gnu/packages/python.scm (python-scipy)[inputs]: Remove "atlas", add "lapack"
>   and "openblas".
> * gnu/packages/python.scm (python-scipy)[arguments]: Replace phase
>   "set-environment-variables" with "configure-openblas".

OK.

> From 79d29126037cd227b01b3a193bf016ec9e12b4fb Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 12 Jun 2015 11:34:39 +0200
> Subject: [PATCH 3/3] gnu: python-scikit-learn: Use OpenBLAS instead of ATLAS.
>
> * gnu/packages/python.scm (python-scikit-learn)[inputs]: Replace "atlas" with
>   "openblas".

Please mention how the phases are modified in the commit log.

Otherwise OK.

Thanks!

Ludo’.