Re: [PATCH] gnu: guile-static: Use Linux syscalls only on Linux systems.

[Ludovic Courtès]

Manolis Ragkousis <address@hidden> skribis:

> Because of "guile-linux-syscalls.patch" current form, I end up getting
> no <sys/mount.h> found when Hurd it targeted.
> I added #ifdef __LINUX__ so the patch will be used only on Linux systems.
>
> From ac6bab86b2ae5509e29aea15125f31ea18c0015f Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Sat, 23 May 2015 22:10:34 +0300
> Subject: [PATCH] gnu: guile-static: Use Linux syscalls only on Linux systems.
>
> * gnu/packages/patches/guile-linux-syscalls.patch: Use Linux
>   syscalls only on Linux systems.

This must be:

  #ifdef __linux__

Lower-case.  I don’t think __LINUX__ is ever defined.  (See the output
of “cpp -dM /dev/null|grep -i linux”.)

Also, s/Linux systems/Linux-based systems/

OK with these changes.

(This change is acceptable because so far this patch is used only for
the initrd Guile, and there’s no initrd on GNU/Hurd.

Note that eventually, when you start porting GuixSD to GNU/Hurd, you’ll
notice that we rely on libc’s ‘mount’ and ‘umount’ functions.  These are
currently not implemented on GNU/Hurd, but it’s “just a matter” of
implementing them in terms of ‘file_set_translator’ & co., which is
mostly done in the Hurd’s utils/{,u}mount.c.)

Thanks!

Ludo’.