[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] services: Add console-keymap service.
|
From: |
Alex Kost |
|
Subject: |
Re: [PATCH] services: Add console-keymap service. |
|
Date: |
Thu, 30 Apr 2015 19:22:24 +0300 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Ludovic Courtès (2015-04-29 23:23 +0300) wrote:
> Alex Kost <address@hidden> skribis:
>
> [...]
>
>> + (documentation
>> + (string-append "Load '" file "' console keymap (loadkeys)."))
>
> Please make it a literal string, thus omitting FILE entirely.
OK, do you mean like this?:
"Load console keymap (loadkeys)."
> Otherwise LGTM, please push.
Thanks.
> Eventually, this should probably be promoted as a field in
> ‘operating-system’, with the service automatically added as part of
> ‘essential-services’. WDYT?
Probably; I don't have an opinion on that.
--
Alex