Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0.

[Ludovic Courtès]

Hi!

Note: this series should go to a ‘glib’ branch, which we’ll get Hydra to
build.

宋文武 <address@hidden> skribis:

> * gnu/packages/glib.scm (gobject-introspection): Update to 1.44.0.
>   [source]: Use mirror://gnome.
>   [arguments]<#:phases>: Remove.
> * gnu/packages/patches/gobject-introspection-cc.patch: Rewrite to
>   set os.environ['CC'] in 'giscanner/__init__.py'.

I don’t know exactly what happened but something broke since the
original patch went in.  The intent was described at
<https://lists.gnu.org/archive/html/guix-devel/2013-11/msg00127.html>.

> +Use gcc as the default C compiler if CC is not set.
> +
> +
> +--- gobject-introspection-1.44.0.orig/giscanner/__init__.py  2014-08-04 
> 22:37:07.000000000 +0800
> ++++ gobject-introspection-1.44.0/giscanner/__init__.py       2015-04-20 
> 17:30:26.507697234 +0800
> +@@ -22,3 +22,5 @@
> + builddir = os.environ.get('UNINSTALLED_INTROSPECTION_BUILDDIR')
> + if builddir is not None:
> +     __path__.append(os.path.join(builddir, 'giscanner'))
> ++if not 'CC' in os.environ:
> ++    os.environ['CC'] = 'gcc'

Is it OK if $CC is set for all the child processes of giscanner?

Assuming there’s no issue in this area, that looks good to me.  And
there’s a whole bunch of CC=gcc that you can remove afterwards.  :-)

Thanks!

Ludo’.