guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add python-pyxdg.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add python-pyxdg.
Date: Tue, 14 Apr 2015 11:52:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ricardo Wurmus <address@hidden> skribis:

> One of the tests is failing.  I do not know why a PNG image is detected
> as 'x-apple-ios-png' rather than the expected 'png', but I suspect it's
> a problem in "shared-mime-info".

Weird.  Normally setting XDG_DATA_DIRS as you did is all it takes, AIUI.

> I made the check phase return #t to
> avoid a build failure.

It would be even better to somehow adjust the test files to skip this
one, but if that’s too much burden, I’m fine with this approach.

> From e9ba9a6bee8ff6d503e1c3f87b407e872afda193 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 14 Apr 2015 08:53:03 +0200
> Subject: [PATCH] gnu: Add python-pyxdg.
>
> * gnu/packages/freedesktop.scm (python-pyxdg, python2-pyxdg): New variables.

[...]

> +    (home-page "http://freedesktop.org/wiki/Software/pyxdg";)
> +    (synopsis "Implementations of freedesktop.org standards in Python")
> +    (description
> +     "PyXDG is a collection of implementations of freedesktop.org standards 
> in
> +Python")

Missing period.  Also, I would make it:

  ... standards in Python: Base Directory, Menu, Desktop Entry, Icon
  Theme, Recent File, and Shared-MIME-Database.

> +    (license lgpl2.0)))

v2.0-only?

Otherwise LGTM.

Thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]