04/05: gnu: commencement: bash-final: Fix build for x86_64-linux with gcc-14.

[guix-commits]

janneke pushed a commit to branch core-packages-team
in repository guix.

commit abde5f5f2813c3325ce83c8a2c9f9b6801520669
Author: Janneke Nieuwenhuizen <janneke@gnu.org>
AuthorDate: Tue Dec 3 17:07:17 2024 +0100

    gnu: commencement: bash-final: Fix build for x86_64-linux with gcc-14.
    
    * gnu/packages/commencement.scm (bash-final)[arguments]: When building for
    x86_64-linux, add -Wno-implicit-function-declaration to #:configule-flags.
    
    Change-Id: Ic1d80d2f50af1958d0f9935b46b76e142db6d297
---
 gnu/packages/commencement.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index 99a896d45c..7128c3c8af 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -3399,7 +3399,15 @@ exec \"$@\" \
 
          #:disallowed-references ,(assoc-ref (%boot3-inputs) "coreutils&co")
 
-         ,@(package-arguments bash))))))
+         ;; gcc-14 implictly uses -Wimplicit-function-declaration
+         ;; which together with -Werror causes:
+         ;; ./enable.def:492:11: error: implicit declaration of function 
‘dlclose’;
+         ;; Doing it here rather than in `bash-minimal' or `static-bash'
+         ;; avoids a boot0-world rebuild.
+         ,@(if (and (target-x86-64?) (target-linux?))
+               `(#:configure-flags
+                 '("CFLAGS=-g -O2 -Wno-implicit-function-declaration"))
+               (package-arguments bash)))))))
 
 (define (%boot4-inputs)
   ;; Now use the final Bash.