02/03: gnu: gsl: Build with ‘-O2 -g’ unconditionally.

[guix-commits]

andreas pushed a commit to branch gsl-upgrade
in repository guix.

commit ac1d3eb4d79e14d19f5c5b0e9e2f6cf477daedae
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Sat Sep 28 19:11:39 2024 +0200

    gnu: gsl: Build with ‘-O2 -g’ unconditionally.
    
    Fixes a regression introduced in
    53bec65c51c3f2b7e318db4dc7a5c3a09ad00214 that would cause gsl to be
    built without optimizations and without debugging symbols (equivalent to
    “-O0 -g0”).
    
    * gnu/packages/maths.scm (gsl)[arguments]: Remove #:make-flags.
    
    Change-Id: I5297e3602bffbb7655d655622cc3d7595f82b25a
---
 gnu/packages/maths.scm | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 1a44e157f9..ad2b26f182 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -688,17 +688,7 @@ precision floating point numbers.")
     (outputs '("out" "static" "debug"))
     (build-system gnu-build-system)
     (arguments
-     (list ;; FIXME: Setting CFLAGS=-fPIC is not only unnecessary, it's also
-           ;; harmful because it removes the default '-O2 -g', meaning that the
-           ;; library ends up being compiled as -O0.  Consequently, some
-           ;; numerical tests fail, notably on i686-linux.  TODO: Remove
-           ;; 'CFLAGS=-fPIC' for all systems and revisit or remove
-           ;; 'disable-failing-tests' phases accordingly.
-           #:make-flags (if (and (not (%current-target-system))
-                                 (string=? (%current-system) "i686-linux"))
-                            #~'()
-                            #~(list "CFLAGS=-fPIC"))
-           #:phases
+     (list #:phases
            #~(modify-phases %standard-phases
                #$@(cond
                    ((and (target-riscv64?)