guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch core-updates updated: gnu: Avoid cycle involving (gnu packages pk


From: guix-commits
Subject: branch core-updates updated: gnu: Avoid cycle involving (gnu packages pkg-config).
Date: Tue, 14 May 2024 11:29:19 -0400

This is an automated email from the git hooks/post-receive script.

civodul pushed a commit to branch core-updates
in repository guix.

The following commit(s) were added to refs/heads/core-updates by this push:
     new f98e90c268 gnu: Avoid cycle involving (gnu packages pkg-config).
f98e90c268 is described below

commit f98e90c2681d15610a6502b07c92c3871f2b56db
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Tue May 14 17:26:46 2024 +0200

    gnu: Avoid cycle involving (gnu packages pkg-config).
    
    Fixes a regression introduced in
    7a26aee61bbbd8e37745ce13433545333eac4505 whereby (gnu packages
    pkg-config) would be caught in a cycle, leading to miscompilation of
    package modules, in turn leading to failure to compute the Guix
    derivation with exceptions like:
    
      1. &package-input-error:
          package: #<package libgc@8.2.4 7fee96c4dc60>
          input: ("_" #<syntax-transformer pkg-config>)
    
    * gnu/packages/pkg-config.scm: Autoload (gnu packages check).
    
    Change-Id: I624e701a0c411b6f3d9ad5e10dca6ad7cf552be4
---
 gnu/packages/pkg-config.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/pkg-config.scm b/gnu/packages/pkg-config.scm
index d1c6c644ac..d5655bd893 100644
--- a/gnu/packages/pkg-config.scm
+++ b/gnu/packages/pkg-config.scm
@@ -29,7 +29,13 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages bash)
-  #:use-module (gnu packages check)
+
+  ;; Note: Because this module defines the 'pkg-config' macro, it cannot be
+  ;; caught in a cycle with other package modules or the macro wouldn't be
+  ;; visible at the time those other modules are compiled.  To fulfill that
+  ;; constraint, load (gnu packages check) lazily.
+  #:autoload   (gnu packages check) (atf kyua)
+
   #:use-module (guix memoization)
   #:export (pkg-config))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]