02/02: gnu: java-testng: Disable one test.

[guix-commits]

rekado pushed a commit to branch python-team
in repository guix.

commit a3a7d51a31957f185e4e6e3059610769d48ffd70
Author: Ricardo Wurmus <rekado@elephly.net>
AuthorDate: Wed Feb 28 19:26:49 2024 +0100

    gnu: java-testng: Disable one test.
    
    * gnu/packages/java.scm (java-testng)[arguments]: Disable parallel
    DataProviderTest; remove trailing #T; do not quote list.
    
    Change-Id: I17847b48ddae10e8d75de4b16a5e03eb538eb418
---
 gnu/packages/java.scm | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 76999f21fc..807ec63f65 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -10787,33 +10787,35 @@ those in Perl and JavaScript.")
                 "0y6vq30i5g276kw0v2bhbvci22ijg7ax49ap2611yqlhbs4d6dqv"))))
     (build-system ant-build-system)
     (arguments
-     `(#:jdk ,icedtea-8; java.util.function
-       #:jar-name "java-testng.jar"
-       #:source-dir "src/main/java"
-       #:phases
-       (modify-phases %standard-phases
-         ;; FIXME: I don't know why these tests fail
+     (list
+      #:jdk icedtea-8; java.util.function
+      #:jar-name "java-testng.jar"
+      #:source-dir "src/main/java"
+      #:phases
+      '(modify-phases %standard-phases
          (add-after 'unpack 'delete-failing-tests
            (lambda _
+             ;; FIXME: I don't know why these tests fail
              (substitute* "src/test/resources/testng.xml"
+               ;; expected:<[0]> but was:<[3]>
                (("<class 
name=\"test.configuration.github1625.TestRunnerIssue1625\"/>") "")
-               (("<class name=\"test.serviceloader.ServiceLoaderTest\" />") 
""))
-             #t))
+               ;; expected [3] but found [2]
+               (("<class name=\"test.serviceloader.ServiceLoaderTest\" />") "")
+               ;; This is a parallel test and we've observed that it fails
+               ;; sometimes.
+               (("<class name=\"test.dataprovider.DataProviderTest\"/>") ""))))
          ;; We don't have groovy
          (add-after 'unpack 'delete-groovy-tests
            (lambda _
              (delete-file-recursively 
"src/test/java/test/dependent/issue1648/")
              (substitute* "src/test/resources/testng.xml"
-               (("<class name=\"test.dependent.issue1648.TestRunner\"/>") ""))
-             #t))
+               (("<class name=\"test.dependent.issue1648.TestRunner\"/>") 
""))))
          (add-before 'build 'copy-resources
            (lambda _
-             (copy-recursively "src/main/resources" "build/classes")
-             #t))
+             (copy-recursively "src/main/resources" "build/classes")))
          (add-before 'check 'copy-test-resources
            (lambda _
-             (copy-recursively "src/test/resources" "build/test-classes")
-             #t))
+             (copy-recursively "src/test/resources" "build/test-classes")))
          (replace 'check
            (lambda _
              (invoke "ant" "compile-tests")