[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
224/229: Revert "lint: Append "/info/refs" to git-reference-url."
From: |
guix-commits |
Subject: |
224/229: Revert "lint: Append "/info/refs" to git-reference-url." |
Date: |
Tue, 28 Mar 2023 22:29:28 -0400 (EDT) |
apteryx pushed a commit to branch master
in repository guix.
commit cc7a79a8ade673cc66249c7b4583a0074348b370
Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
AuthorDate: Tue Mar 28 21:18:27 2023 -0400
Revert "lint: Append "/info/refs" to git-reference-url."
This reverts commit c9af27d4ca733b20f09019f1465d3e5fdc1ec724.
The change causes 'guix lint' to print URI not reachable (403) errors for
GitHub every URLs.
---
guix/lint.scm | 9 +--------
tests/lint.scm | 2 +-
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/guix/lint.scm b/guix/lint.scm
index 3a93ba5325..9eece374ff 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1224,14 +1224,7 @@ password, provided REF's URI is HTTP or HTTPS."
'())))
((git-reference? (origin-uri origin))
(warnings-for-uris
- ;; for atftp, lint produced a warning:
- ;; gnu/packages/networking.scm:2924:5: atftp@0.8.0:
- ;; URI https://git.code.sf.net/p/atftp/code not reachable:
- ;; 404 ("Not Found")
- ;; fix from here: https://issues.guix.gnu.org/62156#3
- (list (string->uri (string-append
- (git-reference-url (origin-uri origin))
- "/info/refs")))))
+ (list (string->uri (git-reference-url (origin-uri origin))))))
((or (svn-reference? (origin-uri origin))
(svn-multi-reference? (origin-uri origin)))
(let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))
diff --git a/tests/lint.scm b/tests/lint.scm
index 71e38550a1..ce22e2355a 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -1052,7 +1052,7 @@
(parameterize ((%http-server-port 0))
(with-http-server `((,redirect ""))
(test-equal "source, git-reference: 301 -> 200"
- (format #f "permanent redirect from ~a/info/refs to ~a"
+ (format #f "permanent redirect from ~a to ~a"
(%local-url) initial-url)
(let ((pkg (dummy-package
"x"
- 171/229: gnu: Add ruby-dotenv-rails., (continued)
- 171/229: gnu: Add ruby-dotenv-rails., guix-commits, 2023/03/28
- 173/229: gnu: Add ruby-pleaserun., guix-commits, 2023/03/28
- 177/229: gnu: ruby-minitest: Update to 5.18.0., guix-commits, 2023/03/28
- 183/229: gnu: ruby-slim: Update to 5.1.0., guix-commits, 2023/03/28
- 192/229: gnu: ruby-shoulda-matchers: Honor #:tests?., guix-commits, 2023/03/28
- 198/229: gnu: Add ruby-rspec-stubbed-env., guix-commits, 2023/03/28
- 204/229: gnu: ruby-hashie: Update to 5.0.0 and enable tests., guix-commits, 2023/03/28
- 208/229: gnu: ruby-omniauth-oauth2: Update to 1.8.0., guix-commits, 2023/03/28
- 217/229: gnu: Add ruby-truthy., guix-commits, 2023/03/28
- 218/229: gnu: ruby-coveralls: Propagate ruby-simplecov and enable tests., guix-commits, 2023/03/28
- 224/229: Revert "lint: Append "/info/refs" to git-reference-url.",
guix-commits <=
- 227/229: services: fstrim: Fix schedule ungexp., guix-commits, 2023/03/28
- 228/229: gnu: geeqie: Update to 2.0.1., guix-commits, 2023/03/28
- 210/229: gnu: ruby-single-cov: Update to 1.9.1., guix-commits, 2023/03/28
- 168/229: gnu: Add ruby-turbo-rails., guix-commits, 2023/03/28
- 181/229: gnu: ruby-protobuf: Update to 3.10.3., guix-commits, 2023/03/28
- 185/229: gnu: ruby-web-console: Update to 4.2.0., guix-commits, 2023/03/28
- 186/229: gnu: Add ruby-minitest-profile., guix-commits, 2023/03/28
- 197/229: gnu: jekyll: Update to 4.3.2 and enable tests., guix-commits, 2023/03/28
- 199/229: gnu: Add ruby-silent-stream., guix-commits, 2023/03/28
- 202/229: gnu: Add ruby-rspec-block-is-expected., guix-commits, 2023/03/28