guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[shepherd] 07/07: service: 'stop' no longer prints an extra "has been st


From: Ludovic Courtès
Subject: [shepherd] 07/07: service: 'stop' no longer prints an extra "has been stopped" message.
Date: Fri, 24 Mar 2023 13:31:41 -0400 (EDT)

civodul pushed a commit to branch master
in repository shepherd.

commit e2d324ee673d1a0ebcc1e2db7a5d795706003e71
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Fri Mar 24 15:01:41 2023 +0100

    service: 'stop' no longer prints an extra "has been stopped" message.
    
    This message was redundant with those printed by 'service-controller'.
    More importantly, it could be misleading: SERVICE might be in the
    'stopping' state at this point, in which case (running? service) returns #f
    and the "could not be stopped" message would wrongfully be printed.
    
    * modules/shepherd/service.scm (stop): Remove redundant and possibly
    misleading message.
---
 modules/shepherd/service.scm | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm
index f678ab6..7cd36fd 100644
--- a/modules/shepherd/service.scm
+++ b/modules/shepherd/service.scm
@@ -795,13 +795,6 @@ is not already running, and will return SERVICE's 
canonical name in a list."
                  (put-message notification #f)
                  (caught-error key args))))))
 
-        ;; Status message.
-        (if (running? service)
-            (local-output (l10n "Service ~a could not be stopped.")
-                          name)
-            (local-output (l10n "Service ~a has been stopped.")
-                          name))
-
         (when (transient? service)
           (put-message (current-registry-channel)
                        `(unregister ,(list service)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]