[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
01/02: services: shepherd: Open /dev/null as O_CLOEXEC.
|
From: |
guix-commits |
|
Subject: |
01/02: services: shepherd: Open /dev/null as O_CLOEXEC. |
|
Date: |
Sat, 10 Sep 2022 18:21:01 -0400 (EDT) |
civodul pushed a commit to branch master
in repository guix.
commit 081bb6a7bd9642ee3d5bb9b697c24f89535416de
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Sat Sep 10 23:19:02 2022 +0200
services: shepherd: Open /dev/null as O_CLOEXEC.
Failing to do that, that file descriptor could be inherited by child
processes as of Shepherd 0.9.2.
* gnu/services/shepherd.scm (shepherd-configuration-file): Open
/dev/null as O_CLOEXEC.
---
gnu/services/shepherd.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/services/shepherd.scm b/gnu/services/shepherd.scm
index 4fd4b2a497..a8f6db9ce2 100644
--- a/gnu/services/shepherd.scm
+++ b/gnu/services/shepherd.scm
@@ -387,7 +387,7 @@ as shepherd package."
;; call; this avoids situations where services wrongfully lead
;; PID 1 to read from stdin (the console), which users may not
;; have access to (see <https://bugs.gnu.org/23697>).
- (redirect-port (open-input-file "/dev/null")
+ (redirect-port (open "/dev/null" (logior O_RDONLY O_CLOEXEC))
(current-input-port)))))
(scheme-file "shepherd.conf" config)))