02/02: berlin: Update TODO and remove extraneous needed-for-boot? in config.

[Maxim Cournoyer]

apteryx pushed a commit to branch master
in repository maintenance.

commit 38c7c876556d2d82a6316b0272b45a4ef7df297d
Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
AuthorDate: Thu Mar 3 13:22:11 2022 -0500

    berlin: Update TODO and remove extraneous needed-for-boot? in config.
    
    * hydra/berlin.scm (%common-btrfs-options): 'rootflags' is now
    supported.  Preserve the degraded option as it is useful for
    unattended reboots, and update the TODO to mention the state of the
    Btrfs array should be monitored.
    [file-systems]: Remove the 'create-mount-point?' fields from the
    '/mnt/old-gnu' and '/mnt/old-root-fs' mount points, as they were set
    to the default value (#f) anyway.
---
 hydra/berlin.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/hydra/berlin.scm b/hydra/berlin.scm
index b58827d..10e1e9b 100644
--- a/hydra/berlin.scm
+++ b/hydra/berlin.scm
@@ -146,8 +146,9 @@ Happy hacking!\n"))
 
 (define %btrfs-raid-uuid "16ff18e1-eb41-4224-8df6-80d3b53c411a")
 
-;;; TODO: Honor rootflags in the initrd, then remove degraded (see:
-;;; https://issues.guix.gnu.org/40998).
+;;; TODO: Implement some mcron job that monitors the absent of a disk
+;;; in the array, or IO related errors in dmesg, so that we can notice
+;;; if the Btrfs becomes degraded.
 (define %common-btrfs-options '(("compress-force" . "zstd")
                                 ("space_cache" . "v2")
                                 "degraded"))
@@ -237,7 +238,6 @@ Happy hacking!\n"))
                    (device (uuid "a6455b66-59d2-40bd-bddb-0c572bb62a2f"))
                    (mount-point "/mnt/old-gnu")
                    (create-mount-point? #t)
-                   (needed-for-boot? #f)
                    (mount? #f)
                    (type "ext4"))
                  ;; Access root file system without bind mounts.
@@ -245,7 +245,6 @@ Happy hacking!\n"))
                    (device (file-system-label "my-root"))
                    (mount-point "/mnt/old-root-fs")
                    (create-mount-point? #t)
-                   (needed-for-boot? #f)
                    (mount? #f)
                    (type "ext4"))
                  %base-file-systems))