02/05: services: MySQL: Bind to localhost only by default.

[guix-commits]

mbakke pushed a commit to branch master
in repository guix.

commit 27d7cdbf87e7a4520f93ee3914139215abf94e68
Author: Marius Bakke <marius@gnu.org>
AuthorDate: Sat Nov 28 01:46:22 2020 +0100

    services: MySQL: Bind to localhost only by default.
    
    * gnu/services/databases.scm (<mysql-configuration>): Add BIND-ADDRESS 
field.
    (mysql-configuration-file): Adjust accordingly.
    * doc/guix.texi (Database Services): Document it.
---
 doc/guix.texi              | 4 ++++
 gnu/services/databases.scm | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index f0c95f5..ae43fb6 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -19138,6 +19138,10 @@ or @var{mysql}.
 For MySQL, a temporary root password will be displayed at activation time.
 For MariaDB, the root password is empty.
 
+@item @code{bind-address} (default: @code{"127.0.0.1"})
+The IP on which to listen for network connections.  Use @code{"0.0.0.0"}
+to bind to all available network interfaces.
+
 @item @code{port} (default: @code{3306})
 TCP port on which the database server listens for incoming connections.
 
diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm
index bb0a0c2..8fd87a5 100644
--- a/gnu/services/databases.scm
+++ b/gnu/services/databases.scm
@@ -465,6 +465,7 @@ storage:
   mysql-configuration make-mysql-configuration
   mysql-configuration?
   (mysql mysql-configuration-mysql (default mariadb))
+  (bind-address mysql-configuration-bind-address (default "127.0.0.1"))
   (port mysql-configuration-port (default 3306))
   (extra-content mysql-configuration-extra-content (default "")))
 
@@ -481,10 +482,11 @@ storage:
 
 (define mysql-configuration-file
   (match-lambda
-    (($ <mysql-configuration> mysql port extra-content)
+    (($ <mysql-configuration> mysql bind-address port extra-content)
      (mixed-text-file "my.cnf" "[mysqld]
 datadir=/var/lib/mysql
 socket=/run/mysqld/mysqld.sock
+bind-address=" bind-address "
 port=" (number->string port) "
 " extra-content "
 "))))