07/09: packages: Ignore return value of origin snippets.

[guix-commits]

civodul pushed a commit to branch core-updates
in repository guix.

commit 325d00e61993ddaa674f6e85e099d570866f8258
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Tue Nov 24 23:29:19 2020 +0100

    packages: Ignore return value of origin snippets.
    
    * guix/packages.scm (patch-and-repack): Ignore return value of SNIPPET
    and remove warning about non #t return value.
---
 guix/packages.scm | 31 +++++++++++--------------------
 1 file changed, 11 insertions(+), 20 deletions(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index bdd03a6..7d8d02c 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -728,26 +728,17 @@ specifies modules in scope when evaluating SNIPPET."
 
               (for-each apply-patch '#+patches)
 
-              (let ((result #+(if snippet
-                                  #~(let ((module (make-fresh-user-module)))
-                                      (module-use-interfaces!
-                                       module
-                                       (map resolve-interface '#+modules))
-                                      ((@ (system base compile) compile)
-                                       '#+snippet
-                                       #:to 'value
-                                       #:opts %auto-compilation-options
-                                       #:env module))
-                                  #~#t)))
-                ;; Issue a warning unless the result is #t.
-                (unless (eqv? result #t)
-                  (format (current-error-port) "\
-## WARNING: the snippet returned `~s'.  Return values other than #t
-## are deprecated.  Please migrate this package so that its snippet
-## reports errors by raising an exception, and otherwise returns #t.~%"
-                          result))
-                (unless result
-                  (error "snippet returned false")))
+              #+(if snippet
+                    #~(let ((module (make-fresh-user-module)))
+                        (module-use-interfaces!
+                         module
+                         (map resolve-interface '#+modules))
+                        ((@ (system base compile) compile)
+                         '#+snippet
+                         #:to 'value
+                         #:opts %auto-compilation-options
+                         #:env module))
+                    #~#t)
 
               (chdir "..")