02/04: Clean up some unused code in the compare controller

[Christopher Baines]

cbaines pushed a commit to branch master
in repository data-service.

commit 80c6fbd1ac6454519c99958797a04ad390217c60
Author: Christopher Baines <mail@cbaines.net>
AuthorDate: Thu Nov 19 20:59:02 2020 +0000

    Clean up some unused code in the compare controller
---
 guix-data-service/web/compare/controller.scm | 30 +++-------------------------
 1 file changed, 3 insertions(+), 27 deletions(-)

diff --git a/guix-data-service/web/compare/controller.scm 
b/guix-data-service/web/compare/controller.scm
index 5cc0493..2ef8204 100644
--- a/guix-data-service/web/compare/controller.scm
+++ b/guix-data-service/web/compare/controller.scm
@@ -504,18 +504,7 @@
               #:extra-headers http-headers-for-unchanging-content)))))))
 
 (define (render-compare/package-derivations mime-types
-                                    query-parameters)
-  (define (derivations->alist derivations)
-    (map (match-lambda
-           ((file-name system target buildstatus)
-            `((file_name . ,file-name)
-              (system . ,system)
-              (target . ,target)
-              (build_status . ,(if (string=? buildstatus "")
-                                   "unknown"
-                                   buildstatus)))))
-         derivations))
-
+                                            query-parameters)
   (if (any-invalid-query-parameters? query-parameters)
       (case (most-appropriate-mime-type
              '(application/json text/html)
@@ -545,8 +534,7 @@
       (let ((base-commit    (assq-ref query-parameters 'base_commit))
             (target-commit  (assq-ref query-parameters 'target_commit))
             (systems        (assq-ref query-parameters 'system))
-            (targets        (assq-ref query-parameters 'target))
-            (build-statuses (assq-ref query-parameters 'build_status)))
+            (targets        (assq-ref query-parameters 'target)))
         (letpar& ((data
                    (with-thread-postgresql-connection
                     (lambda (conn)
@@ -594,17 +582,6 @@
 
 (define (render-compare-by-datetime/package-derivations mime-types
                                                         query-parameters)
-  (define (derivations->alist derivations)
-    (map (match-lambda
-           ((file-name system target buildstatus)
-            `((file_name . ,file-name)
-              (system . ,system)
-              (target . ,target)
-              (build_status . ,(if (string=? buildstatus "")
-                                   "unknown"
-                                   buildstatus)))))
-         derivations))
-
   (if (any-invalid-query-parameters? query-parameters)
       (case (most-appropriate-mime-type
              '(application/json text/html)
@@ -628,8 +605,7 @@
             (target-branch   (assq-ref query-parameters 'target_branch))
             (target-datetime (assq-ref query-parameters 'target_datetime))
             (systems         (assq-ref query-parameters 'system))
-            (targets         (assq-ref query-parameters 'target))
-            (build-statuses  (assq-ref query-parameters 'build_status)))
+            (targets         (assq-ref query-parameters 'target)))
         (letpar&
             ((base-revision-details
               (with-thread-postgresql-connection