guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch version-1.2.0 updated: services: mpd: Do not eagerly look for a u


From: guix-commits
Subject: branch version-1.2.0 updated: services: mpd: Do not eagerly look for a user.
Date: Fri, 06 Nov 2020 09:01:47 -0500

This is an automated email from the git hooks/post-receive script.

apteryx pushed a commit to branch version-1.2.0
in repository guix.

The following commit(s) were added to refs/heads/version-1.2.0 by this push:
     new 0c5d0c5  services: mpd: Do not eagerly look for a user.
0c5d0c5 is described below

commit 0c5d0c57d370b34f3ba677838deaa8baf7bca58a
Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
AuthorDate: Fri Nov 6 08:54:27 2020 -0500

    services: mpd: Do not eagerly look for a user.
    
    Running 'guix system search mpd' would throw a backtrace because the
    mpd-shepherd-service service start Gexp contained an unquoted call to
    'getpwnam', which would look for a missing 'mpd' user and fail.
    
    * gnu/services/audio.scm (mpd-shepherd-service): gexp-unquote only the
    relevant variable rather than the whole expression.
---
 gnu/services/audio.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index 37f2efa..5d33032 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -143,11 +143,11 @@ audio_output {
              #:pid-file #$(mpd-file-name config "pid")
              #:environment-variables
              ;; Required to detect PulseAudio when run under a user account.
-             '(#$(string-append
-                   "XDG_RUNTIME_DIR=/run/user/"
-                   (number->string
+             (list (string-append
+                    "XDG_RUNTIME_DIR=/run/user/"
+                    (number->string
                      (passwd:uid
-                       (getpwnam (mpd-configuration-user config))))))
+                      (getpwnam #$(mpd-configuration-user config))))))
              #:log-file #$(mpd-file-name config "log")))
    (stop  #~(make-kill-destructor))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]