guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

03/03: build-system/python: Revert changing of phase order.


From: guix-commits
Subject: 03/03: build-system/python: Revert changing of phase order.
Date: Tue, 20 Oct 2020 21:21:26 -0400 (EDT)

apteryx pushed a commit to branch core-updates
in repository guix.

commit dd4a4603bec437bd055ec42ed99afd122864eed0
Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
AuthorDate: Mon Oct 19 17:14:04 2020 -0400

    build-system/python: Revert changing of phase order.
    
    Commit c94a2864d4 moved the 'check' phase back into its original place 
before
    the 'install' phase, but such a change would require adapting the definition
    of many Python packages which have come to rely on such phase ordering.
    
    * guix/build/python-build-system.scm (%standard-phases): Move the check 
phase
    back after the install phase, and update comment.
---
 guix/build/python-build-system.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/guix/build/python-build-system.scm 
b/guix/build/python-build-system.scm
index a790c49..4a07496 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -265,7 +265,8 @@ installed with setuptools."
 (define %standard-phases
   ;; The build phase only builds C extensions and copies the Python sources,
   ;; while the install phase copies then byte-compiles the sources to the
-  ;; prefix directory.
+  ;; prefix directory.  The check phase is moved after the installation phase
+  ;; to ease testing the built package.
   (modify-phases gnu:%standard-phases
     (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980)
     (add-after 'ensure-no-mtimes-pre-1980 'enable-bytecode-determinism
@@ -273,8 +274,9 @@ installed with setuptools."
     (delete 'bootstrap)
     (delete 'configure)                 ;not needed
     (replace 'build build)
-    (replace 'check check)
+    (delete 'check)                     ;moved after the install phase
     (replace 'install install)
+    (add-after 'install 'check check)
     (add-after 'install 'wrap wrap)
     (add-before 'strip 'rename-pth-file rename-pth-file)))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]