03/08: channels: Remove 'signature' from <channel-introduction>.

[guix-commits]

civodul pushed a commit to branch master
in repository guix.

commit 22a969925769dcbe968b224016f5af00079d68ff
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Thu Jun 25 15:37:02 2020 +0200

    channels: Remove 'signature' from <channel-introduction>.
    
    In the end signing the commit/key pair does not buy us much.  Someone
    publishing a valid but different commit/key pair would effectively be
    publishing a different channel, which could be a fork (made by a former
    authorized developer) or simply a mirror.  In the latter case, there's
    nothing to be gained by publishing a different commit/key pair.
    
    * guix/channels.scm (<channel-introduction>)[signature]: Remove.
    (make-channel-introduction): Adjust accordingly.
---
 guix/channels.scm | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/guix/channels.scm b/guix/channels.scm
index 5f48e6f..922c99a 100644
--- a/guix/channels.scm
+++ b/guix/channels.scm
@@ -128,22 +128,19 @@
 
 ;; Channel introductions.  A "channel introduction" provides a commit/signer
 ;; pair that specifies the first commit of the authentication process as well
-;; as its signer's fingerprint.  The pair must be signed by the signer of that
-;; commit so that only them may emit this introduction.  Introductions are
-;; used to bootstrap trust in a channel.
+;; as its signer's fingerprint.  Introductions are used to bootstrap trust in
+;; a channel.
 (define-record-type <channel-introduction>
-  (%make-channel-introduction first-signed-commit first-commit-signer
-                              signature)
+  (%make-channel-introduction first-signed-commit first-commit-signer)
   channel-introduction?
-  (first-signed-commit  channel-introduction-first-signed-commit) ;hex string
-  (first-commit-signer  channel-introduction-first-commit-signer) ;bytevector
-  (signature            channel-introduction-signature))          ;string
+  (first-signed-commit  channel-introduction-first-signed-commit)  ;hex string
+  (first-commit-signer  channel-introduction-first-commit-signer)) ;bytevector
 
 (define (make-channel-introduction commit signer)
   "Return a new channel introduction: COMMIT is the introductory where
 authentication starts, and SIGNER is the OpenPGP fingerprint (a bytevector) of
 the signer of that commit."
-  (%make-channel-introduction commit signer #f))
+  (%make-channel-introduction commit signer))
 
 (define (openpgp-fingerprint->bytevector str)
   "Convert STR, an OpenPGP fingerprint (hexadecimal string with whitespace),